Skip to content

fix href optionals #13595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

fix href optionals #13595

merged 1 commit into from
May 12, 2025

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented May 12, 2025 •
edited
Loading

TODO

  • changeset
  • address PR feedback

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 12, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e1fd22b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori linked an issue May 12, 2025 that may be closed by this pull request
href() builder produces invalid URL on optional segments #13055
Closed
@pcattori pcattori force-pushed the pedro/href-optionals branch from 1b5ba36 to 43c8b06 Compare May 12, 2025 18:31
@pcattori pcattori force-pushed the pedro/href-optionals branch from 43c8b06 to e1fd22b Compare May 12, 2025 18:53
@pcattori pcattori marked this pull request as ready for review May 12, 2025 18:53
@pcattori pcattori merged commit 17ba033 into dev May 12, 2025
10 of 11 checks passed
@pcattori pcattori deleted the pedro/href-optionals branch May 12, 2025 20:21
@pcattori pcattori mentioned this pull request May 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

href() builder produces invalid URL on optional segments
1 participant
@pcattori